Fixed: Rdbms and Redshift Properties #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Redshift.py and Postgres.py. Changed Redshift's do_truncate_table and queries to properties. Fixed reference to properties as self.<property> rather than previous methods self.<property_method>().
|
Link back to PR #1444 involving update_id |
|
LGTM |
Tarrasch
added a commit
that referenced
this pull request
Dec 28, 2015
Fixed: Rdbms and Redshift Properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as PR #1393 b/c I screwed up the rebase...
Changed Rdbms' update_id to a @Property. Appropriate changes were made to Redshift.py and Postgres.py. Also changed Redshift's do_truncate_table and queries to properties. Finally, fixed references to properties as self. rather than their previous method forms self.<property_method>().