-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding several extra options to bigquery load configuration #1619
Conversation
It seems like the email that you're commiting from is not associated with your GitHub account. Can you please add your email to your GitHub account? By doing this you increase the traceability for this project. Thank you. |
This PR is changing a contrib module. Can you do a |
@mikekap @blacker @DeaconDesperado Can you review these changes as per @Tarrasch request? |
@Tarrasch I have chosen not to show my email publicly on github in the settings. |
You don't need to show it publicly. Just make sure that the email you committed with is among your github emails. (Typically, you commit with your work email, but currently your github account is only having your private email, though you can have multiple emails). Is it ok? :) |
You can run (sorry if I sound like a robot, I'm just trying out the new "saved replies" features on GitHub :)) |
LGTM |
@Tarrasch when is your next release going to go out? |
It seems like this patch has many unneeded commits all belonging to the same logical change. Can you please amend the commits into one single or perhaps fewer commits (whatever you think is sensible)? Thanks for your cooperation on keeping the commit log clean and distraction-free. Instructions for git beginners: I usually run |
Well. Currently nobody is really owning luigi. But if enough people nag me I usually will do things like making a pypi release. :) |
👍 |
@jpotts18 so we just released 2.1.0 last week, therefore this merge didn't make it in, but, hm, I think we could approach more continuous rollout of releases, even bumping PyPI on every code merge... |
Thanks @ulzha it's fine I'll just use my own version until you do another one. Also @Tarrasch This might be a helpful thing for you to install to mention contributors that are identified in the blame https://github.com/facebook/mention-bot |
@jpotts18, actually we just released 2.1.1 Oh, thanks for mentioning mention-bot! I'll check it out :) |
@jpotts18, ok I added it. Let's see how it plays out :) |
@jpotts18 I don't wait on official pypi releases, I install via |
I have basically added missing configuration options that were not exposed for CSV usage.
https://cloud.google.com/bigquery/docs/reference/v2/jobs#configuration.load