Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding several extra options to bigquery load configuration #1619

Merged
merged 4 commits into from
Apr 4, 2016
Merged

Adding several extra options to bigquery load configuration #1619

merged 4 commits into from
Apr 4, 2016

Conversation

jpotts18
Copy link
Contributor

I have basically added missing configuration options that were not exposed for CSV usage.

https://cloud.google.com/bigquery/docs/reference/v2/jobs#configuration.load

@Tarrasch
Copy link
Contributor

It seems like the email that you're commiting from is not associated with your GitHub account. Can you please add your email to your GitHub account? By doing this you increase the traceability for this project. Thank you.

@Tarrasch
Copy link
Contributor

This PR is changing a contrib module. Can you do a git blame and look for other contributors who have edited those files and @-mention them to summon them as reviewers of this patch?

@jpotts18 jpotts18 mentioned this pull request Mar 31, 2016
@jpotts18
Copy link
Contributor Author

@mikekap @blacker @DeaconDesperado Can you review these changes as per @Tarrasch request?

@jpotts18
Copy link
Contributor Author

@Tarrasch I have chosen not to show my email publicly on github in the settings.

@Tarrasch
Copy link
Contributor

You don't need to show it publicly. Just make sure that the email you committed with is among your github emails. (Typically, you commit with your work email, but currently your github account is only having your private email, though you can have multiple emails). Is it ok? :)

@Tarrasch
Copy link
Contributor

You can run git show --format='%ae' to see what email you commited with. Make sure it's present among your emails registered at GitHub

(sorry if I sound like a robot, I'm just trying out the new "saved replies" features on GitHub :))

@mikekap
Copy link
Contributor

mikekap commented Mar 31, 2016

LGTM

@jpotts18
Copy link
Contributor Author

@Tarrasch when is your next release going to go out?

@Tarrasch
Copy link
Contributor

Tarrasch commented Apr 1, 2016

It seems like this patch has many unneeded commits all belonging to the same logical change. Can you please amend the commits into one single or perhaps fewer commits (whatever you think is sensible)? Thanks for your cooperation on keeping the commit log clean and distraction-free.

Instructions for git beginners: I usually run git fetch upstream; git rebase upstream/master; git rebase --interactive HEAD~10 and then follow the interactive instructions. Here upstream is a remote pointing to spotify/luigi.

@Tarrasch
Copy link
Contributor

Tarrasch commented Apr 1, 2016

Well. Currently nobody is really owning luigi. But if enough people nag me I usually will do things like making a pypi release. :)

@blacker
Copy link
Contributor

blacker commented Apr 1, 2016

👍

@Tarrasch Tarrasch merged commit 20f7ce0 into spotify:master Apr 4, 2016
@ulzha
Copy link
Contributor

ulzha commented Apr 4, 2016

@jpotts18 so we just released 2.1.0 last week, therefore this merge didn't make it in, but, hm, I think we could approach more continuous rollout of releases, even bumping PyPI on every code merge...

@jpotts18
Copy link
Contributor Author

jpotts18 commented Apr 7, 2016

Thanks @ulzha it's fine I'll just use my own version until you do another one. Also @Tarrasch This might be a helpful thing for you to install to mention contributors that are identified in the blame https://github.com/facebook/mention-bot

@Tarrasch
Copy link
Contributor

Tarrasch commented Apr 8, 2016

@jpotts18, actually we just released 2.1.1

Oh, thanks for mentioning mention-bot! I'll check it out :)

@Tarrasch
Copy link
Contributor

Tarrasch commented Apr 8, 2016

@jpotts18, ok I added it. Let's see how it plays out :)

@dlstadther
Copy link
Collaborator

@jpotts18 I don't wait on official pypi releases, I install via pip install git+https://github.com/dlstadther/luigi. Or you could install from spotify/luigi if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants