[bigquery] add support for non-legacy SQL #1896
Conversation
|
@ukarlsson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mikekap, @mbruggmann and @jpotts18 to be potential reviewers. |
| def use_legacy_sql(self): | ||
| """Whether to use legacy SQL | ||
| """ | ||
| return True |
There was a problem hiding this comment.
Is using legacy default o_O?
There was a problem hiding this comment.
Hey, sorry had forgot about this PR, yes legacy should be default in order not to break compatibility, it is also still default in the BigQuery console
There was a problem hiding this comment.
Perhaps we can merge PR
|
@ukarlsson, I would love to merge this, but can you get someone else who knows BigQuery to review this? |
|
@Tarrasch We are running something very similar internally as well. Not sure if that qualifies as "knowing BigQuery" but I'd give this a 👍 |
|
@mbruggmann, certainly good enough for me (that you run it in production). Thanks for reviewing. :) |
No description provided.