Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the long-deprecated BooleanParameter #1959

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

Tarrasch
Copy link
Contributor

@Tarrasch Tarrasch commented Dec 9, 2016

Description

That parameter has been deprecated since way over one year. I believe also before 2.0.

The correct parameter to use is BoolParameter.

@mention-bot
Copy link

@Tarrasch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @themalkolm, @freider and @erikbern to be potential reviewers.

@mfcabrera
Copy link
Contributor

This will break so much code. I did not even know it was long deprecated ;) - but I guess is an easy-fix for existing code-base.

@Tarrasch
Copy link
Contributor Author

Tarrasch commented Dec 9, 2016

@mfcabrera, sure, but then you've ignored BooleanParameter is deprecated, use BoolParameter instead being printed out to your console for over a year. So my sympathy is not as high. But actually it's really good for me to know that people still use the deprecated version. I wish maintainers had more time to do deprecations properly, but that takes too much time.

@Tarrasch Tarrasch merged commit fc6a4e1 into spotify:master Dec 12, 2016
Tarrasch added a commit to Tarrasch/luigi that referenced this pull request Dec 21, 2016
@sbliven
Copy link

sbliven commented Jan 30, 2017

FYI, BoolParameter was introduced in 1.0.21. BooleanParameter was deprecated in 2.0.0 and removed in 2.5.0.

@Tarrasch Tarrasch deleted the remove_booleanparameter branch February 2, 2017 02:27
kreczko pushed a commit to kreczko/luigi that referenced this pull request Mar 28, 2017
This was referenced Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants