Enable automatic URL tracking for Spark applications #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with the main repo
- changed `track_url_in_stderr` to `stream_for_searching_tracking_url` according to the latest changes in external_program.py - added tests for spark url tracking in cluster and client modes
Tarrasch
approved these changes
Mar 12, 2019
|
Ok, I'll be back when it's been working long enough. |
|
Hi @Tarrasch, just wanted to inform that the pipeline with these changes applied has been working for last ~2 weeks with no issues observed. |
|
Awesome. Let's merge then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2661 has provided the mechanism of tracking URL in external programs.
So now we can enable it for Spark applications:
If spark application is run in cluster mode, the string matching the pattern
tracking URL: (https?://.*)\sis searched.If spark application is run in client mode, the string matching the pattern
Bound (?:.*) to (?:.*), and started at (https?://.*)\sis searched.In both cases the searching is performed in
stderrstream.Motivation and Context
To enable URL tracking in Spark applications.
Have you tested this? If so, how?
The PR contains some new unit tests + existing tests were run locally