Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import ABC from collections.abc instead of collections for Python 3.9 compatibility #2895

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Import ABC from collections.abc instead of collections for Python 3.9 compatibility #2895

merged 1 commit into from
Feb 13, 2020

Conversation

tirkarthi
Copy link
Contributor

Description

Import ABC from collections.abc for Python 3.9 compatibility since Python 3.9 raises an ImportError.

Motivation and Context

Improves Python 3.9 compatibility.

dlstadther
dlstadther approved these changes Feb 8, 2020
View reviewed changes
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@honnix honnix merged commit 5732416 into spotify:master Feb 13, 2020
@tirkarthi
Copy link
Contributor Author

Thanks for the review and merge :)

@honnix honnix mentioned this pull request Jun 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlstadther dlstadther dlstadther approved these changes

@honnix honnix Awaiting requested review from honnix

@Tarrasch Tarrasch Awaiting requested review from Tarrasch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tirkarthi @dlstadther @honnix