Improve optional parameters #3079
Conversation
adrien-berchet
requested review from
dlstadther,
Tarrasch and
a team
as code owners
adrien-berchet
force-pushed
the
optional_params
branch
from
79f3733
to
dbb2886
Compare
|
Do you think that the fail in CI is due to this PR? I don't think so but I am not sure. |
The errors listed don't look related to these changes. @ckiosidis do you have insights? This was the first time i've looked at PR-specific unittests for Luigi since the move to Github Actions. I assume |
adrien-berchet
force-pushed
the
optional_params
branch
from
dbb2886
to
3cef59d
Compare
|
Hello |
| class OptionalListParameter(OptionalParameterMixin, ListParameter): | ||
| """Class to parse optional list parameters.""" | ||
|
|
||
| expected_type = tuple |
There was a problem hiding this comment.
is OptionalListParameter intentionally a tuple? As opposed to a list?
There was a problem hiding this comment.
It is intentional because the _warn_on_wrong_param_type is called after normalize which calls recursively_freeze on the value, thus the list is transformed into a tuple before the type is checked. That's why we expect a tuple here.
There was a problem hiding this comment.
Ah right. I vaguely recall that confusion. I believe I added List Parameter and Tuple Parameter separately and later wished I hadn't added both. But alas, we have them both and treat them nearly the same.
There was a problem hiding this comment.
Indeed it would be simpler to have only one of these 2.
adrien-berchet
force-pushed
the
optional_params
branch
from
5a82a8a
to
d9e86f1
Compare
| class OptionalListParameter(OptionalParameterMixin, ListParameter): | ||
| """Class to parse optional list parameters.""" | ||
|
|
||
| expected_type = tuple |
There was a problem hiding this comment.
Ah right. I vaguely recall that confusion. I believe I added List Parameter and Tuple Parameter separately and later wished I hadn't added both. But alas, we have them both and treat them nearly the same.
Description
Update OptionalParameter and add several other parameter classes for other types.
Motivation and Context
Parameters raise warnings when their default value is None. As far as I know, it is only possible to use OptionalParameter for string type so I added optional classes for other types.
Have you tested this? If so, how?
I have included unit tests.