Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rerun command snippet in "show error" modal #3117

Merged

Conversation

leifdenby
Copy link
Contributor

Description

When running very complex tasks with many nested dependencies I find myself wanting to re-run just a few tasks that failed instead of the parent task (so as to avoid the time-consuming checks for completed/passed/etc required tasks).
Because of how the task information is rendered in the visualiser there wasn't an easy way to copy-paste the information there. I've added the rendering of a snippet in the "show error" modal which contains the exact command to copy-paste into a terminal to re-run a specific task.

Motivation and Context

To save time when debugging failing tasks

Have you tested this? If so, how?

Yes, I tested with the example task class below

import luigi                                    
                                                
class FailTask(luigi.Task):                     
    arg_1 = luigi.Parameter()                   
    arg_2 = luigi.FloatParameter()              
    arg_3 = luigi.OptionalParameter(default=0.2)
                                                
    def run(self):                              
        raise Exception(42)                     

Screenshot of the new element:
Screenshot 2021-11-03 at 09 07 51

To facilitate quick re-run of failed tasks this commit adds a text
snippet to the "Show error" modal in the task visualiser. The scheduler
api call was modified to include the extra information needed to create
call command.
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlstadther dlstadther merged commit 857deff into spotify:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants