OptionalParameter in ExternalPythonProgramTask #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated ExternalPythonProgramTask parameters type to OptionalParameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now,
ExternalPythonProgramTaskparameters are simpleParameter.But the default for both of them is
Noneand they are used only if they are not None.If the value for any of them is not provided, a warning is raised, for example:
UserWarning: Parameter "extra_pythonpath" with value "None" is not of type string.Therefore I think that the appropriate type is OptionalParameter instead.
PS: First pull request for me, I hope I'm doing it right. Otherwise please help me understand what's wrong. Thanks