Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope SQLA session so object lifespans rendering #3153

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Scope SQLA session so object lifespans rendering #3153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 12 additions & 8 deletions luigi/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,28 +245,32 @@ def from_utc(utcTime, fmt=None):

class RecentRunHandler(BaseTaskHistoryHandler):
def get(self):
tasks = self._scheduler.task_history.find_latest_runs()
self.render("recent.html", tasks=tasks)
with self._scheduler.task_history._session(None) as session:
tasks = self._scheduler.task_history.find_latest_runs(session)
self.render("recent.html", tasks=tasks)


class ByNameHandler(BaseTaskHistoryHandler):
def get(self, name):
tasks = self._scheduler.task_history.find_all_by_name(name)
self.render("recent.html", tasks=tasks)
with self._scheduler.task_history._session(None) as session:
tasks = self._scheduler.task_history.find_all_by_name(name, session)
self.render("recent.html", tasks=tasks)


class ByIdHandler(BaseTaskHistoryHandler):
def get(self, id):
task = self._scheduler.task_history.find_task_by_id(id)
self.render("show.html", task=task)
with self._scheduler.task_history._session(None) as session:
task = self._scheduler.task_history.find_task_by_id(id, session)
self.render("show.html", task=task)


class ByParamsHandler(BaseTaskHistoryHandler):
def get(self, name):
payload = self.get_argument('data', default="{}")
arguments = json.loads(payload)
tasks = self._scheduler.task_history.find_all_by_parameters(name, session=None, **arguments)
self.render("recent.html", tasks=tasks)
with self._scheduler.task_history._session(None) as session:
tasks = self._scheduler.task_history.find_all_by_parameters(name, session=session, **arguments)
self.render("recent.html", tasks=tasks)


class RootPathHandler(BaseTaskHistoryHandler):
Expand Down