Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update random seed for python 3.11 compatibility #3204

Merged
merged 1 commit into from Nov 4, 2022

Conversation

davidesba
Copy link
Contributor

Fix compatibility error with python 3.11: #3202

Description

Update worker process random seed to be compatible with python3.11

Motivation and Context

Fixes issue: #3202

Have you tested this? If so, how?

Run tests and tested on local project

Fix compatibility error with python 3.11: spotify#3202
@davidesba davidesba requested review from dlstadther and a team as code owners November 3, 2022 11:42
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A benign change and tests still look good; Thanks for the contribution!

(Please note that Luigi's test suite only covers up to 3.9; you may find other attributes within 3.10 or 3.11 which might cause problems. There was an attempt a few months ago to update for 3.10 support and testing, but I am unsure of the current state of that work.)

@dlstadther dlstadther merged commit 9177eee into spotify:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants