Add spark-master configuration & PySpark1xJob support for --jars #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
| @@ -378,6 +378,9 @@ def run(self): | |||
| py_files = self.py_files() | |||
| if py_files != []: | |||
| options += ['--py-files', ','.join(py_files)] | |||
| dependency_jars = self.dependency_jars() | |||
| if dependency_jars != []: | |||
There was a problem hiding this comment.
Nitpick: I see that xxx != [] is the current convention in this file (see line 379 for example), but I'd prefer if dependency_jars:.
There was a problem hiding this comment.
I agree @berkerpeksag.
There's also room for a bit more refactoring as ATM the run methods in PySpark1xJob and Spark1xJob are mostly duplicated.
I can have a go at it in separate PR?
Tarrasch
added a commit
that referenced
this pull request
Mar 3, 2015
Add spark-master configuration & PySpark1xJob support for --jars
|
Thanks @jthi3rry! Can you please also fix @berkerpeksag's comment in a new PR? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.