Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Semigroup#combineAllOption? #23

Closed
nevillelyh opened this issue Nov 21, 2019 · 0 comments
Closed

Optimize Semigroup#combineAllOption? #23

nevillelyh opened this issue Nov 21, 2019 · 0 comments

Comments

@nevillelyh
Copy link
Contributor

Could be a performance improvement if T is expensive to create/copy, but probably only worth it if Typeclass[T] for all parameters have custom combineAllOption, which we can detect with p.typeclass.getClass.getMethod("combineAllOption") == classOf[Semigroup].getClass.getMethod(...) but that feels a bit hacky.
nevillelyh added a commit that referenced this issue Dec 30, 2019
@nevillelyh
optimize combineAllOption, fix #23
346b19d
nevillelyh added a commit that referenced this issue Dec 30, 2019
@nevillelyh
optimize combineAllOption, fix #23
0f15d0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nevillelyh