Map based converter for flat model #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When object is not a tree, use a map of qualified keys to values as converter source. Filtering keys when cursor cursor selects field removes need to wrap the return type into a Value
Draft
RustedBones
commented
Oct 24, 2023
clairemcginty
approved these changes
Oct 24, 2023
RustedBones
force-pushed
the
map-converter
branch
from
7f3803f
to
082c815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When object is not a tree, use a map of qualified keys to values as converter source.
Filtering keys when cursor selects field removes the need to wrap the return type into a Value