Update mapping.md #873
Merged
Update mapping.md #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 51 51
Lines 1777 1777
Branches 175 175
=======================================
Hits 1692 1692
Misses 85 85 ☔ View full report in Codecov by Sentry. |
regadas
reviewed
Dec 11, 2023
Comment on lines
+47
to
+49
| 9. More information on Parquet logical type schemas can be found [here](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md). Time types are available at multiple precisions; import `magnolify.parquet.logical.micros._`, `magnolify.avro.logical.millis._`, or `magnolify.avro.logical.nanos._` accordingly. | ||
| 10. See [protobuf.md](https://github.com/spotify/magnolify/blob/master/docs/protobuf.md) for more | ||
| 11. Logical types available at micro- or milli-second precision; import `magnolify.avro.logical.micros._` or `magnolify.avro.logical.millis._` accordingly. BigQuery-compatible conversions are available in `magnolify.avro.logical.bigquery._`. |
RustedBones
reviewed
Dec 12, 2023
docs/mapping.md
Outdated
| | `org.joda.time.LocalDate` | `INT`<sup>11</sup> | - | - | - | - | - | - | | ||
| | `org.joda.time.DateTime` | `INT`<sup>11</sup> | - | - | - | - | - | - | | ||
| | `org.joda.time.LocalTime` | `INT`<sup>11</sup> | - | - | - | - | - | - | | ||
| | `java.util.UUID` | `STRING`<sup>4</sup> | - | ByteString (16 bytes) | - | `FIXED[16]`<sup>9</sup> | - | - | |
There was a problem hiding this comment.
I'm not sure the 9. note holds for the UUID in parquet here
There was a problem hiding this comment.
good point! Removed it.
RustedBones
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi: PR diff is much easier to read w/ rich formatting turned on!
Change summary:
AvroCompat's effect on array type representation