remove Guava from missinglink-core #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as this class depends on Guava's Joiner class and a future commit will remove Guava from the missinglink-core module altogether
In the interest of having as few dependencies as possible in the core module, this commit removes Guava from it. Guava was only really used in three ways in the core module: 1. Immutable collection types 2. Preconditions checks 3. Joiner for concatenating strings I replaced 1 with a mix of `Collection.singleton()`, `singletonList()` etc., along with vanilla ArrayList / HashMap usage. The classes generated by AutoMatter for POJOs will make copies of any collections passed in, so I skipped a lot of the usage of Guava's Immutable types for making copies of collections before passing them into the generated POJOs. Use of the Preconditions static methods to throw NullPointerExceptions or IllegalArgumentExceptions I replaced with `java.util.Objects.checkNotNull()` or vanilla if-else checks. The plugin module still uses Guava; removing it from that module was out of scope for this change (anyone using Missinglink in other build tools will just depend on the core module). Closes #60.
spkrka
approved these changes
Oct 21, 2019
since we have changed the dependencies, and return types of some public methods
spkrka
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of having as few dependencies as possible in the core
module, this commit removes Guava from it.
Guava was only really used in three ways in the core module:
concatenating strings
I replaced 1 with a mix of
Collection.singleton(),singletonList()etc., along with vanilla ArrayList / HashMap usage. The classes generated
by AutoMatter for POJOs will make copies of any collections passed in, so I
skipped a lot of the usage of Guava's Immutable types for making copies of
collections before passing them into the generated POJOs.
Use of the Preconditions static methods to throw NullPointerExceptions or
IllegalArgumentExceptions I replaced with
java.util.Objects.checkNotNull()or vanilla if-else checks.The plugin module still uses Guava; removing it from that module was out of
scope for this change (anyone using Missinglink in other build tools will
just depend on the core module).
Closes #60.