-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement experimental dependency analysis #63
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
core/src/main/java/com/spotify/missinglink/ConflictFilter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Copyright (c) 2019 Spotify AB | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.spotify.missinglink; | ||
|
|
||
| import java.util.Set; | ||
|
|
||
| public interface ConflictFilter { | ||
|
|
||
| /** | ||
| * | ||
| * @param className class to test | ||
| * @return true if a missing class should trigger a conflict, otherwise false | ||
| */ | ||
| boolean filterMissingClass(String className); | ||
|
|
||
| /** | ||
| * | ||
| * @param className class to test | ||
| * @return a set of artifacts that the class was expected to be in | ||
| */ | ||
| Set<String> getFoundIn(String className); | ||
|
|
||
| } |
36 changes: 36 additions & 0 deletions
36
core/src/main/java/com/spotify/missinglink/EmptyConflictFilter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Copyright (c) 2019 Spotify AB | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.spotify.missinglink; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.Set; | ||
|
|
||
| public class EmptyConflictFilter implements ConflictFilter { | ||
| public static final ConflictFilter INSTANCE = new EmptyConflictFilter(); | ||
|
|
||
| private EmptyConflictFilter() { | ||
| } | ||
|
|
||
| @Override | ||
| public boolean filterMissingClass(String className) { | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public Set<String> getFoundIn(String className) { | ||
| return Collections.emptySet(); | ||
| } | ||
| } |
110 changes: 110 additions & 0 deletions
110
core/src/main/java/com/spotify/missinglink/dependencies/ArtifactCache.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /* | ||
| * Copyright (c) 2019 Spotify AB | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.spotify.missinglink.dependencies; | ||
|
|
||
| import org.json.JSONObject; | ||
| import org.json.JSONTokener; | ||
|
|
||
| import java.io.File; | ||
| import java.io.FileInputStream; | ||
| import java.io.FileOutputStream; | ||
| import java.io.IOException; | ||
| import java.io.InputStreamReader; | ||
| import java.io.OutputStreamWriter; | ||
| import java.io.Reader; | ||
| import java.io.Writer; | ||
| import java.nio.charset.StandardCharsets; | ||
| import java.util.Set; | ||
| import java.util.concurrent.Callable; | ||
| import java.util.stream.Collectors; | ||
| import java.util.zip.GZIPInputStream; | ||
| import java.util.zip.GZIPOutputStream; | ||
|
|
||
| import static java.lang.System.getProperty; | ||
|
|
||
| class ArtifactCache { | ||
| private final File dir; | ||
|
|
||
| private ArtifactCache(File dir) { | ||
| this.dir = dir; | ||
| if (!dir.exists()) { | ||
| if (!dir.mkdirs()) { | ||
| throw new RuntimeException("Could not create directory: " + dir); | ||
| } | ||
| } | ||
| if (!dir.isDirectory()) { | ||
| throw new RuntimeException("Expected a directory: " + dir); | ||
| } | ||
| } | ||
|
|
||
| static ArtifactCache getDefault() { | ||
| String homeDir = getProperty("user.home"); | ||
| File root = new File(homeDir + "/.m2/repository/dependency-data"); | ||
| return new ArtifactCache(root); | ||
| } | ||
|
|
||
| ArtifactContainer resolve( | ||
| Resolver resolver, Coordinate coordinate, | ||
| Callable<ArtifactContainer> fallback) { | ||
| if (coordinate.isSnapshot()) { | ||
| return invoke(fallback); | ||
| } | ||
| String filename = coordinate.toString().replace(':', '_') + ".json.gz"; | ||
| File file = new File(dir, filename); | ||
| try { | ||
| if (file.exists()) { | ||
| JSONObject data = getObject(file); | ||
| IncompleteArtifact artifactContainer = JsonReader.fromJson(data); | ||
| Set<ArtifactContainer> dependencies = artifactContainer.getDependencies().stream() | ||
| .map(resolver::resolve) | ||
| .collect(Collectors.toSet()); | ||
|
|
||
| return artifactContainer.complete(dependencies); | ||
| } else { | ||
| ArtifactContainer artifactContainer = invoke(fallback); | ||
| JSONObject jsonObject = JsonWriter.toJsonObject(artifactContainer); | ||
| writeObject(file, jsonObject); | ||
| return artifactContainer; | ||
| } | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| private ArtifactContainer invoke(Callable<ArtifactContainer> fallback) { | ||
| try { | ||
| return fallback.call(); | ||
| } catch (RuntimeException e) { | ||
| throw e; | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| private void writeObject(File file, JSONObject object) throws IOException { | ||
| try (Writer writer = new OutputStreamWriter(new GZIPOutputStream( | ||
| new FileOutputStream(file)), StandardCharsets.UTF_8)) { | ||
| object.write(writer, 2, 0); | ||
| } | ||
| } | ||
|
|
||
| private JSONObject getObject(File file) throws IOException { | ||
| try (Reader reader = new InputStreamReader(new GZIPInputStream( | ||
| new FileInputStream(file)), StandardCharsets.UTF_8)) { | ||
| return new JSONObject(new JSONTokener(reader)); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this change was unnecessary, will revert it!