Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure RxJava-related errors don't throw NPEs #96

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

pettermahlen
Copy link
Member

The getErrorHandler() method can return null; the safe way is to use the
onError(Throwable) hook.

The getErrorHandler() method can return null; the safe way is to use the
onError(Throwable) hook.
@pettermahlen pettermahlen requested a review from togi March 4, 2020 13:43
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #96   +/-   ##
=========================================
  Coverage     78.12%   78.12%           
  Complexity      276      276           
=========================================
  Files            72       72           
  Lines          1431     1431           
  Branches         85       85           
=========================================
  Hits           1118     1118           
  Misses          297      297           
  Partials         16       16
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/spotify/mobius/rx2/RxMobius.java 68.42% <ø> (ø) 1 <0> (ø) ⬇️
...in/java/com/spotify/mobius/rx2/RxConnectables.java 56.81% <0%> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b446f35...fdd456f. Read the comment docs.

@pettermahlen pettermahlen merged commit ca50480 into spotify:master Mar 5, 2020
@pettermahlen pettermahlen deleted the rx-error-handling branch March 5, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants