Allow backwards compatibility when setting float parameters to strings. #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an introduced in #167; existing code that may set VST parameter values to strings (i.e.:
plugin.frequency = "123.45 dB"
) will now throw aValueError
due to the fact that Pedalboard now (as of v0.6.5) expects afloat
instead of astr
.To fix this, Pedalboard now:
.label
parameterfloat
-based parameter with astr
float
-based parameter with astr
that has its.label
suffixed on the end.units
parameter onAudioPluginParameter
instances, for better discoverability than.label
.