Fix parsing of MP3 files that start with ID3 tags and end with LYRICS3 blocks. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobot
force-pushed
the
psobot/lyrics3-again
branch
from
315847e
to
4e7bcdf
Compare
psobot
force-pushed
the
psobot/lyrics3-again
branch
from
2890b64
to
c4b85f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a knock-on to #164, which added support for parsing MP3 files containing the non-standard Lyrics3 extension.
That change was not properly rolled out - the code was added and the tests passed, but some test audio files still failed. It seems that the original MP3 parser's bug is only hit if the MP3 file contains an ID3 tag at its start. A test MP3 fixture is added as part of this PR to enable a more complete regression test.
(cc @f90)