-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mxid and xid metrics #26
Conversation
mxid_age = get_max_mxid_age(db_connection) | ||
if not mxid_age: | ||
return [] | ||
ratio = mxid_age // WRAPAROUND_LIMIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use /
instead of //
here.
xid_age = get_max_xid_age(db_connection) | ||
if not xid_age: | ||
return [] | ||
ratio = xid_age // WRAPAROUND_LIMIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use /
instead of //
here.
Tested manually on existing database instance, seems to work as expected 👍 Noticed that documentation in README.md needs to be updated to reflect that "Database Local Directory Based (Global) Metrics" are now handled as "Database Cluster (Global) Metrics". Other than that it looks good to me. |
LGTM 👍 |
No description provided.