Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Serialization issue as well as min/max bound for uniform sampling #129

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

idreeskhan
Copy link
Contributor

Fixes #127 #128

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #129 into master will decrease coverage by 31.23%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #129       +/-   ##
==========================================
- Coverage   71.33%   40.1%   -31.24%     
==========================================
  Files          29      29               
  Lines        1392    1394        +2     
  Branches      163     163               
==========================================
- Hits          993     559      -434     
- Misses        399     835      +436
Flag Coverage Δ
#ratatoolCli 4.44% <0%> (-0.01%) ⬇️
#ratatoolCommon 100% <ø> (ø) ⬆️
#ratatoolDiffy 26.99% <0%> (-0.05%) ⬇️
#ratatoolExamples 19.35% <0%> (-0.04%) ⬇️
#ratatoolSampling ?
#ratatoolScalacheck 82.11% <ø> (ø) ⬆️
#ratatoolShapeless 5.37% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
...pling/src/main/scala/com/spotify/scio/Random.scala 0% <0%> (-77.42%) ⬇️
...ol/samplers/util/SamplerSCollectionFunctions.scala 0% <0%> (-91.84%) ⬇️
...ala/com/spotify/ratatool/samplers/BigSampler.scala 0% <0%> (-59.43%) ⬇️
...la/com/spotify/ratatool/samplers/AvroSampler.scala 0% <0%> (-96.88%) ⬇️
...main/scala/com/spotify/ratatool/io/ParquetIO.scala 0% <0%> (-96.16%) ⬇️
.../scala/com/spotify/ratatool/samplers/Sampler.scala 0% <0%> (-90%) ⬇️
...cala/com/spotify/ratatool/samplers/util/Util.scala 0% <0%> (-90%) ⬇️
...rc/main/scala/com/spotify/ratatool/io/AvroIO.scala 0% <0%> (-82.06%) ⬇️
...scala/com/spotify/ratatool/io/TableRowJsonIO.scala 0% <0%> (-76.93%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e242ba...a1705af. Read the comment docs.

Copy link
Contributor

@catherinejelder catherinejelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@idreeskhan idreeskhan merged commit 908b3bc into master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants