Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Respect avro.java.string type #709

Merged
merged 1 commit into from
Feb 28, 2024
Merged

(fix) Respect avro.java.string type #709

merged 1 commit into from
Feb 28, 2024

Conversation

RustedBones
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.84%. Comparing base (9ef661c) to head (fc96972).

Files Patch % Lines
...om/spotify/ratatool/scalacheck/AvroGenerator.scala 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage   70.96%   70.84%   -0.12%     
==========================================
  Files          44       44              
  Lines        1822     1825       +3     
  Branches      316      300      -16     
==========================================
  Hits         1293     1293              
- Misses        529      532       +3     
Flag Coverage Δ
ratatoolCli 2.90% <ø> (ø)
ratatoolCommon 0.00% <ø> (ø)
ratatoolDiffy 32.80% <81.81%> (+0.06%) ⬆️
ratatoolExamples 17.36% <72.72%> (+0.02%) ⬆️
ratatoolSampling 62.66% <81.81%> (+0.55%) ⬆️
ratatoolScalacheck 79.34% <90.90%> (+0.20%) ⬆️
ratatoolShapeless 4.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@benkonz benkonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from scalatestplus-scalacheck to master February 28, 2024 07:42
@RustedBones RustedBones marked this pull request as ready for review February 28, 2024 18:46
@RustedBones RustedBones merged commit 02cb088 into master Feb 28, 2024
1 check passed
@RustedBones RustedBones deleted the avro-java-string branch February 28, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants