Move to SBT Pack instead of Assembly #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 70.11% 69.55% -0.57%
==========================================
Files 22 22
Lines 947 959 +12
Branches 127 127
==========================================
+ Hits 664 667 +3
- Misses 283 292 +9
Continue to review full report at Codecov.
|
jbigred1
reviewed
Apr 17, 2018
| @@ -174,7 +160,6 @@ lazy val ratatoolCli = project | |||
| name := "ratatool-cli", | |||
| libraryDependencies ++= Seq( | |||
| "com.github.scopt" %% "scopt" % scoptVersion, | |||
| "org.apache.parquet" % "parquet-avro" % parquetVersion, | |||
There was a problem hiding this comment.
did we mean to remove this
There was a problem hiding this comment.
Yea I think it ended up there as an artifact during the project restructure but seems to work fine without
jbigred1
reviewed
Apr 17, 2018
| | Usage: ratatool [bigDiffy|bigSampler|directSampler] [args] | ||
| """.stripMargin | ||
|
|
||
| if (args.isEmpty || !Set("bigDiffy", "bigSampler", "directSampler").contains(args.head)) { |
There was a problem hiding this comment.
can we make these variables constants
jbigred1
reviewed
Apr 17, 2018
| //scalastyle:off cyclomatic.complexity | ||
| def main(args: Array[String]): Unit = { | ||
| val usage = """ | ||
| | Ratatool - a tool for random data generation and sampling |
jbigred1
reviewed
Apr 17, 2018
| } | ||
|
|
||
| val o = opts.get | ||
| o.mode match { |
There was a problem hiding this comment.
instead of get could we do opts.foreach
jbigred1
approved these changes
Apr 17, 2018
|
Yes definitely need to update docs, will roll that into this PR as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78
#77
#76
and potentially #67
We want to be able to move to SBT Pack instead of assembly to simplify the dependency management and avoid conflicts with building the fat jar. To make the usage easier, we reduce to a single main so that there is only one entry point, and those who brew install can still use
ratatool [args]to run commandsShould keep spotify/homebrew-public#24 in sync and merge that PR when this one is merged