New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert test suite from mocha to jest #183

Closed

krissalvador27 opened this issue Oct 30, 2019 · 1 comment

Labels

infra

Contributor

krissalvador27 commented Oct 30, 2019

Our tests currently leverage mocha, chai and sinon. We should migrate our test suite to use jest.

It's Spotify's preferred Javascript test framework and aligns web-scripts out of the box eslint configuration. See here.
Jest is a kitchen sink that works out of the box, removing the need to manage multiple dependencies.
Jest is overtaking mocha in community adoption (as of 10/29/19 5.1 million vs 3.3 million weekly downloads). Adopting the tools used more frequently by our community can reduce barrier to contribution.

krissalvador27 added the infra label

krissalvador27 mentioned this issue

Fix warnings in tests and add SankeyNodeTerminal tests #184

Merged

PRTTMPRPHT mentioned this issue

Migrate tests to jest #291

Merged

Collaborator

ekh64 commented Feb 24, 2022

Oh hey, we did this!

ekh64 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment