Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace default classNames #51

Closed
dandelany opened this issue Feb 9, 2018 · 2 comments
Closed

Namespace default classNames #51

dandelany opened this issue Feb 9, 2018 · 2 comments

Comments

@dandelany
Copy link
Contributor

Currently by default we render (& style) elements with very general classNames eg. chart-bar or xy-plot which could accidentally collide with classNames that users would use in their apps. Per suggestion from @ekh64 we should prefix these with a namespace eg rc-chart-bar. rc- seems best, but I want to check out rc-slider (common slider library) and similar to make sure we don't use the same prefix they do.
@mindyyuan
Copy link

I believe this is resolved? @krissalvador27

@krissalvador27
Copy link
Contributor

This is resolved via #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dandelany @krissalvador27 @mindyyuan