Namespace css classes + update class and style props where applicable #66

krissalvador27 · 2018-05-17T18:45:35Z

namespaced all css files to have rct-
added class and style props where applicable
there is a breaking change for prop markerLineClass -> markerLineClassName in PieChart

…Chart

mindyyuan

looks good to me

joshbDev

I know that you just did a lot of namespacing around RCT, and I don't think it should go into this PR, but you may want to variable your namespace in the future, that way you can change your namespace quickly if you need to, then in the strings that you're declaring doing something like class=${NAMESPACE_CLASS}-area-barchart

other than that though looks good

joshbDev · 2018-05-21T15:11:35Z

src/MarkerLineChart.js

@@ -225,7 +237,8 @@ export default class MarkerLineChart extends React.Component {
    if (!_.every([x1, x2, y1, y2], _.isFinite)) return null;
    return (
      <line
-        className="marker-line"
+        className={`${getValue(lineClassName, d, i)}`}


does this need to be in strings?

not sure what you mean by this but to clarify getValue takes as its first argument a value or accessor function. so if lineClassName is a value (a string) then it's returned, if it's a function then it's the result of that function applied with the rest of the arguments

joshbDev · 2018-05-21T15:12:17Z

src/MarkerLineChart.js

+    const tickType = getTickType(this.props);
+    return (
+      <g className="rct-marker-line-chart">
+        {tickType === "RangeValue"


is RangeValue something used across multiple files, and if so should this string be abstracted into a constants file?

on inspection it's a tickType conceptually used only for MarkerLineChart

joshbDev · 2018-05-21T15:12:58Z

src/RangeRect.js

@@ -85,7 +85,7 @@ export default class RangeRect extends React.Component {
      `RangeRect.props.yScale is not a valid d3 scale`
    );

-    const className = `chart-range-rect ${this.props.className || ""}`;
+    const className = `${this.props.className || ""}`;


can remove the string

* Histogram improvements + tests (#57) * Add react-docgen to devDependencies * Histogram improvements - calculate yDomain and based off given data. Include mouse interaction and styling props. Add tests. * Test horizontal props for BarChart * Histogram - move binning into render function to handle dynamic data, make value prop a function, improve docs, remove unused code * rebuild docs * Integrate prettier & eslint code styles + add linting as part of npm test (#58) * Add prettier & eslint code style rules * Include eslint process with npm test * Clean up and refactor (#59) * Add prettier & eslint code style rules * Remove legacy code and evaluate any todos * Only send valid XYPlot props to children. Resolves #22 * Check against master list of scaleTypes * Implement invertX and invertY scale * Alphabetically sort props displayed on docs * Update documentation for x and y axis labels and titles * Clean up code and todos * includeXZero and includeYZero props + test * feature(yaml): add ci/cd (#60) * feature(version): version bump (#61) * feature(version): version bump * feature(lockfile): add a lockfile * Clean up multiple warning logs and fix regression on children components not getting their defaultProps (#64) * Include css in root and add less -> css to build process (#63) * Include css in root and add to build process * Update readme directions to run examples * add AreaBarChart spec (#65) * Namespace css classes + update class and style props where applicable (#66) * AreaChartBar namespace * AreaChart namespace * AreaHeatMap namespace + accessor class and style funcs * BarChart update documentation * ColorHeatmap namespace and update documentation * FunnelChart namespace and accessors * Add lineStyle and lineClassName to KDE and remove unused prop in LineChart * MarketLineChart namespace and class and style accessors * RangeBarChart namespace * ScatterPlot namespace * PieChart documentation and updates * XYPlot namespace and underlying components * Add classes to linechart, remove unused styles * Namespace SankeyDiagram and updates to PieChart * Update tests * Update docs * Add backwards compatibility for markerLineClass * Update docs * Use className from props for RangeRect * Add disableMouseWheelZoom prop to ZoomContainer (#67) * Add disable mousewheel prop to reactochart * Update docs * 0.4.6 release (#68)

* Histogram improvements + tests (#57) * Add react-docgen to devDependencies * Histogram improvements - calculate yDomain and based off given data. Include mouse interaction and styling props. Add tests. * Test horizontal props for BarChart * Histogram - move binning into render function to handle dynamic data, make value prop a function, improve docs, remove unused code * rebuild docs * Integrate prettier & eslint code styles + add linting as part of npm test (#58) * Add prettier & eslint code style rules * Include eslint process with npm test * Clean up and refactor (#59) * Add prettier & eslint code style rules * Remove legacy code and evaluate any todos * Only send valid XYPlot props to children. Resolves #22 * Check against master list of scaleTypes * Implement invertX and invertY scale * Alphabetically sort props displayed on docs * Update documentation for x and y axis labels and titles * Clean up code and todos * includeXZero and includeYZero props + test * feature(yaml): add ci/cd (#60) * feature(version): version bump (#61) * feature(version): version bump * feature(lockfile): add a lockfile * Clean up multiple warning logs and fix regression on children components not getting their defaultProps (#64) * Include css in root and add less -> css to build process (#63) * Include css in root and add to build process * Update readme directions to run examples * add AreaBarChart spec (#65) * Namespace css classes + update class and style props where applicable (#66) * AreaChartBar namespace * AreaChart namespace * AreaHeatMap namespace + accessor class and style funcs * BarChart update documentation * ColorHeatmap namespace and update documentation * FunnelChart namespace and accessors * Add lineStyle and lineClassName to KDE and remove unused prop in LineChart * MarketLineChart namespace and class and style accessors * RangeBarChart namespace * ScatterPlot namespace * PieChart documentation and updates * XYPlot namespace and underlying components * Add classes to linechart, remove unused styles * Namespace SankeyDiagram and updates to PieChart * Update tests * Update docs * Add backwards compatibility for markerLineClass * Update docs * Use className from props for RangeRect * Add disableMouseWheelZoom prop to ZoomContainer (#67) * Add disable mousewheel prop to reactochart * Update docs * 0.4.6 release (#68) * Update README.md to include directions for importing styles (#71) * add ColorHeatmap spec (#72) * add ColorHeatmap spec * generate build docs * Add step labeling to sankey (#73) * Add step labeling functionality to sankey * Update tests for sankey to include step labels * Update docs * Add step labeling functionality to sankey * Update tests for sankey to include step labels * Update docs * PR review + documentation * Better ternary * Update changelog and bump version (#74)

* Histogram improvements + tests (#57) * Add react-docgen to devDependencies * Histogram improvements - calculate yDomain and based off given data. Include mouse interaction and styling props. Add tests. * Test horizontal props for BarChart * Histogram - move binning into render function to handle dynamic data, make value prop a function, improve docs, remove unused code * rebuild docs * Integrate prettier & eslint code styles + add linting as part of npm test (#58) * Add prettier & eslint code style rules * Include eslint process with npm test * Clean up and refactor (#59) * Add prettier & eslint code style rules * Remove legacy code and evaluate any todos * Only send valid XYPlot props to children. Resolves #22 * Check against master list of scaleTypes * Implement invertX and invertY scale * Alphabetically sort props displayed on docs * Update documentation for x and y axis labels and titles * Clean up code and todos * includeXZero and includeYZero props + test * feature(yaml): add ci/cd (#60) * feature(version): version bump (#61) * feature(version): version bump * feature(lockfile): add a lockfile * Clean up multiple warning logs and fix regression on children components not getting their defaultProps (#64) * Include css in root and add less -> css to build process (#63) * Include css in root and add to build process * Update readme directions to run examples * add AreaBarChart spec (#65) * Namespace css classes + update class and style props where applicable (#66) * AreaChartBar namespace * AreaChart namespace * AreaHeatMap namespace + accessor class and style funcs * BarChart update documentation * ColorHeatmap namespace and update documentation * FunnelChart namespace and accessors * Add lineStyle and lineClassName to KDE and remove unused prop in LineChart * MarketLineChart namespace and class and style accessors * RangeBarChart namespace * ScatterPlot namespace * PieChart documentation and updates * XYPlot namespace and underlying components * Add classes to linechart, remove unused styles * Namespace SankeyDiagram and updates to PieChart * Update tests * Update docs * Add backwards compatibility for markerLineClass * Update docs * Use className from props for RangeRect * Add disableMouseWheelZoom prop to ZoomContainer (#67) * Add disable mousewheel prop to reactochart * Update docs * 0.4.6 release (#68) * Update README.md to include directions for importing styles (#71) * add ColorHeatmap spec (#72) * add ColorHeatmap spec * generate build docs * Add step labeling to sankey (#73) * Add step labeling functionality to sankey * Update tests for sankey to include step labels * Update docs * Add step labeling functionality to sankey * Update tests for sankey to include step labels * Update docs * PR review + documentation * Better ternary * Update changelog and bump version (#74) * add AreaHeatmap, FunnelChart spec (#77) * add AreaHeatmap spec * add FunnelChart spec * feature(Standards): add in code of conduct and NOTICE file (#76) * Zoom container spec (#78) * Zoom Container spec * Added npm run test-files * Add eslint to tests (#79) * Add tests to linter * Update tests with lint-fix * Fix growl dependency via mocha (#80) * Fix growl dependency on mocha * Update package lock json * Update version and changelog (#81)

…#66) * AreaChartBar namespace * AreaChart namespace * AreaHeatMap namespace + accessor class and style funcs * BarChart update documentation * ColorHeatmap namespace and update documentation * FunnelChart namespace and accessors * Add lineStyle and lineClassName to KDE and remove unused prop in LineChart * MarketLineChart namespace and class and style accessors * RangeBarChart namespace * ScatterPlot namespace * PieChart documentation and updates * XYPlot namespace and underlying components * Add classes to linechart, remove unused styles * Namespace SankeyDiagram and updates to PieChart * Update tests * Update docs * Add backwards compatibility for markerLineClass * Update docs * Use className from props for RangeRect

* Histogram improvements + tests (#57) * Add react-docgen to devDependencies * Histogram improvements - calculate yDomain and based off given data. Include mouse interaction and styling props. Add tests. * Test horizontal props for BarChart * Histogram - move binning into render function to handle dynamic data, make value prop a function, improve docs, remove unused code * rebuild docs * Integrate prettier & eslint code styles + add linting as part of npm test (#58) * Add prettier & eslint code style rules * Include eslint process with npm test * Clean up and refactor (#59) * Add prettier & eslint code style rules * Remove legacy code and evaluate any todos * Only send valid XYPlot props to children. Resolves #22 * Check against master list of scaleTypes * Implement invertX and invertY scale * Alphabetically sort props displayed on docs * Update documentation for x and y axis labels and titles * Clean up code and todos * includeXZero and includeYZero props + test * feature(yaml): add ci/cd (#60) * feature(version): version bump (#61) * feature(version): version bump * feature(lockfile): add a lockfile * Clean up multiple warning logs and fix regression on children components not getting their defaultProps (#64) * Include css in root and add less -> css to build process (#63) * Include css in root and add to build process * Update readme directions to run examples * add AreaBarChart spec (#65) * Namespace css classes + update class and style props where applicable (#66) * AreaChartBar namespace * AreaChart namespace * AreaHeatMap namespace + accessor class and style funcs * BarChart update documentation * ColorHeatmap namespace and update documentation * FunnelChart namespace and accessors * Add lineStyle and lineClassName to KDE and remove unused prop in LineChart * MarketLineChart namespace and class and style accessors * RangeBarChart namespace * ScatterPlot namespace * PieChart documentation and updates * XYPlot namespace and underlying components * Add classes to linechart, remove unused styles * Namespace SankeyDiagram and updates to PieChart * Update tests * Update docs * Add backwards compatibility for markerLineClass * Update docs * Use className from props for RangeRect * Add disableMouseWheelZoom prop to ZoomContainer (#67) * Add disable mousewheel prop to reactochart * Update docs * 0.4.6 release (#68)

* Histogram improvements + tests (#57) * Add react-docgen to devDependencies * Histogram improvements - calculate yDomain and based off given data. Include mouse interaction and styling props. Add tests. * Test horizontal props for BarChart * Histogram - move binning into render function to handle dynamic data, make value prop a function, improve docs, remove unused code * rebuild docs * Integrate prettier & eslint code styles + add linting as part of npm test (#58) * Add prettier & eslint code style rules * Include eslint process with npm test * Clean up and refactor (#59) * Add prettier & eslint code style rules * Remove legacy code and evaluate any todos * Only send valid XYPlot props to children. Resolves #22 * Check against master list of scaleTypes * Implement invertX and invertY scale * Alphabetically sort props displayed on docs * Update documentation for x and y axis labels and titles * Clean up code and todos * includeXZero and includeYZero props + test * feature(yaml): add ci/cd (#60) * feature(version): version bump (#61) * feature(version): version bump * feature(lockfile): add a lockfile * Clean up multiple warning logs and fix regression on children components not getting their defaultProps (#64) * Include css in root and add less -> css to build process (#63) * Include css in root and add to build process * Update readme directions to run examples * add AreaBarChart spec (#65) * Namespace css classes + update class and style props where applicable (#66) * AreaChartBar namespace * AreaChart namespace * AreaHeatMap namespace + accessor class and style funcs * BarChart update documentation * ColorHeatmap namespace and update documentation * FunnelChart namespace and accessors * Add lineStyle and lineClassName to KDE and remove unused prop in LineChart * MarketLineChart namespace and class and style accessors * RangeBarChart namespace * ScatterPlot namespace * PieChart documentation and updates * XYPlot namespace and underlying components * Add classes to linechart, remove unused styles * Namespace SankeyDiagram and updates to PieChart * Update tests * Update docs * Add backwards compatibility for markerLineClass * Update docs * Use className from props for RangeRect * Add disableMouseWheelZoom prop to ZoomContainer (#67) * Add disable mousewheel prop to reactochart * Update docs * 0.4.6 release (#68) * Update README.md to include directions for importing styles (#71) * add ColorHeatmap spec (#72) * add ColorHeatmap spec * generate build docs * Add step labeling to sankey (#73) * Add step labeling functionality to sankey * Update tests for sankey to include step labels * Update docs * Add step labeling functionality to sankey * Update tests for sankey to include step labels * Update docs * PR review + documentation * Better ternary * Update changelog and bump version (#74)

* Histogram improvements + tests (#57) * Add react-docgen to devDependencies * Histogram improvements - calculate yDomain and based off given data. Include mouse interaction and styling props. Add tests. * Test horizontal props for BarChart * Histogram - move binning into render function to handle dynamic data, make value prop a function, improve docs, remove unused code * rebuild docs * Integrate prettier & eslint code styles + add linting as part of npm test (#58) * Add prettier & eslint code style rules * Include eslint process with npm test * Clean up and refactor (#59) * Add prettier & eslint code style rules * Remove legacy code and evaluate any todos * Only send valid XYPlot props to children. Resolves #22 * Check against master list of scaleTypes * Implement invertX and invertY scale * Alphabetically sort props displayed on docs * Update documentation for x and y axis labels and titles * Clean up code and todos * includeXZero and includeYZero props + test * feature(yaml): add ci/cd (#60) * feature(version): version bump (#61) * feature(version): version bump * feature(lockfile): add a lockfile * Clean up multiple warning logs and fix regression on children components not getting their defaultProps (#64) * Include css in root and add less -> css to build process (#63) * Include css in root and add to build process * Update readme directions to run examples * add AreaBarChart spec (#65) * Namespace css classes + update class and style props where applicable (#66) * AreaChartBar namespace * AreaChart namespace * AreaHeatMap namespace + accessor class and style funcs * BarChart update documentation * ColorHeatmap namespace and update documentation * FunnelChart namespace and accessors * Add lineStyle and lineClassName to KDE and remove unused prop in LineChart * MarketLineChart namespace and class and style accessors * RangeBarChart namespace * ScatterPlot namespace * PieChart documentation and updates * XYPlot namespace and underlying components * Add classes to linechart, remove unused styles * Namespace SankeyDiagram and updates to PieChart * Update tests * Update docs * Add backwards compatibility for markerLineClass * Update docs * Use className from props for RangeRect * Add disableMouseWheelZoom prop to ZoomContainer (#67) * Add disable mousewheel prop to reactochart * Update docs * 0.4.6 release (#68) * Update README.md to include directions for importing styles (#71) * add ColorHeatmap spec (#72) * add ColorHeatmap spec * generate build docs * Add step labeling to sankey (#73) * Add step labeling functionality to sankey * Update tests for sankey to include step labels * Update docs * Add step labeling functionality to sankey * Update tests for sankey to include step labels * Update docs * PR review + documentation * Better ternary * Update changelog and bump version (#74) * add AreaHeatmap, FunnelChart spec (#77) * add AreaHeatmap spec * add FunnelChart spec * feature(Standards): add in code of conduct and NOTICE file (#76) * Zoom container spec (#78) * Zoom Container spec * Added npm run test-files * Add eslint to tests (#79) * Add tests to linter * Update tests with lint-fix * Fix growl dependency via mocha (#80) * Fix growl dependency on mocha * Update package lock json * Update version and changelog (#81)

krissalvador27 added 16 commits May 15, 2018 12:53

AreaChartBar namespace

d78a015

AreaChart namespace

3b72375

AreaHeatMap namespace + accessor class and style funcs

311218f

BarChart update documentation

7e4c71f

ColorHeatmap namespace and update documentation

abbe9cf

FunnelChart namespace and accessors

4686b9d

Add lineStyle and lineClassName to KDE and remove unused prop in Line…

587497f

…Chart

MarketLineChart namespace and class and style accessors

f28f3e5

RangeBarChart namespace

f1f2cf1

ScatterPlot namespace

53749ff

PieChart documentation and updates

2acf99b

XYPlot namespace and underlying components

7e75572

Add classes to linechart, remove unused styles

b2fb21c

Namespace SankeyDiagram and updates to PieChart

585ab33

Update tests

4620e18

Update docs

c5bd561

krissalvador27 requested review from ariroseonline, dandelany and joshbDev May 17, 2018 18:45

mindyyuan reviewed May 17, 2018

View reviewed changes

krissalvador27 added 2 commits May 21, 2018 10:41

Add backwards compatibility for markerLineClass

99894c0

Update docs

7a3dec4

joshbDev reviewed May 21, 2018

View reviewed changes

Use className from props for RangeRect

7e5197d

krissalvador27 merged commit 9f8e1f4 into master May 21, 2018

krissalvador27 deleted the namespace-css-files branch May 21, 2018 16:04

krissalvador27 mentioned this pull request May 21, 2018

Add disableMouseWheelZoom prop to ZoomContainer #67

Merged

krissalvador27 mentioned this pull request Jun 28, 2018

Namespace default classNames #51

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Namespace css classes + update class and style props where applicable #66

Namespace css classes + update class and style props where applicable #66

krissalvador27 commented May 17, 2018

mindyyuan left a comment

joshbDev left a comment

joshbDev May 21, 2018

krissalvador27 May 21, 2018

joshbDev May 21, 2018

krissalvador27 May 21, 2018

joshbDev May 21, 2018

krissalvador27 May 21, 2018

Namespace css classes + update class and style props where applicable #66

Namespace css classes + update class and style props where applicable #66

Conversation

krissalvador27 commented May 17, 2018

mindyyuan left a comment

Choose a reason for hiding this comment

joshbDev left a comment

Choose a reason for hiding this comment

joshbDev May 21, 2018

Choose a reason for hiding this comment

krissalvador27 May 21, 2018

Choose a reason for hiding this comment

joshbDev May 21, 2018

Choose a reason for hiding this comment

krissalvador27 May 21, 2018

Choose a reason for hiding this comment

joshbDev May 21, 2018

Choose a reason for hiding this comment

krissalvador27 May 21, 2018

Choose a reason for hiding this comment