Vendor relevant Librosa filter code to avoid runtime dependencies on Numba and libsndfile. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Numba and libsndfile.
psobot
force-pushed
the
psobot/no-librosa-at-runtime
branch
from
a8406f7
to
5c06a66
Compare
omardelarosa
approved these changes
May 11, 2023
psobot
force-pushed
the
psobot/no-librosa-at-runtime
branch
2 times, most recently
from
0dbff1e
to
dec6d05
Compare
psobot
force-pushed
the
psobot/no-librosa-at-runtime
branch
from
dec6d05
to
ec171b6
Compare
psobot
force-pushed
the
psobot/no-librosa-at-runtime
branch
from
e93388d
to
e6e3a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
realbookin another project currently pulls in all of Librosa, which includes a huge dependency chain - includinglibsndfileandnumba, both of which can be painful to install. We only use Librosa for a tiny amount of runtime functionality (generating static data inrealbook.layers.signal), so this PR vendors the relevant ~900 lines of code as part of Realbook itself. This removes the need for a large number of runtime dependencies.