Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveAsCustomOutput and customInput shouldn't require a name. #2447

Closed
jabrouwer82 opened this issue Nov 26, 2019 · 2 comments
Closed

saveAsCustomOutput and customInput shouldn't require a name. #2447

jabrouwer82 opened this issue Nov 26, 2019 · 2 comments

Comments

@jabrouwer82
Copy link

None of the other transformation methods on SCollection or ScioContext require a name to be used, they're all capable of generating a name using private scio internals. My team is writing an internal library utilizing scio and it would be very useful for us to be able to let the name be generated so that we don't have to pass the burden on to our users.

@jabrouwer82
Copy link
Author

Alternatively, perhaps additionally, it would be nice if we could access CallSite in some way to explicitly generate a unique name the same way everything else does!

@jabrouwer82
Copy link
Author

Neville Li helped me understand these can be trivially implemented as SCollection.internal.apply(transform) in our own code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant