Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support toTableReference in BigQueryIO #73

Closed
nevillelyh opened this issue Apr 11, 2016 · 5 comments
Closed

Support toTableReference in BigQueryIO #73

nevillelyh opened this issue Apr 11, 2016 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nevillelyh
Copy link
Contributor

No description provided.

@nevillelyh nevillelyh added the enhancement New feature or request label Apr 11, 2016
@nevillelyh nevillelyh modified the milestone: 0.2.0 Apr 20, 2016
@nevillelyh
Copy link
Contributor Author

https://cloud.google.com/dataflow/java-sdk/JavaDoc/com/google/cloud/dataflow/sdk/io/BigQueryIO.Write#toTableReference-com.google.cloud.dataflow.sdk.transforms.SerializableFunction-

This is the API I'm referring to, which allows saving a single PCollection into multiple BigQuery tables with a BoundedWindow => TableReference function.

@nevillelyh
Copy link
Contributor Author

Not sure if this should be part of Scio though, since it breaks the JobTest semantics. Plus the user can do SCollection#saveAsCustomOutput now.

@andrewsmartin
Copy link
Contributor

Can we close this?

@nevillelyh
Copy link
Contributor Author

Let's leave it open for a bit longer. I might think about a way to do this properly.

@nevillelyh
Copy link
Contributor Author

@samschlegel also found this: apache/beam@35db745

We can maybe add these as methods on a implicit class and to skip JobTest support.

@nevillelyh nevillelyh added the good first issue Good for newcomers label Oct 11, 2017
@regadas regadas mentioned this issue Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nevillelyh @andrewsmartin