This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add deadline to flyte grpc client #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablocasares
commented
Apr 14, 2023
|
|
||
| return new FlyteAdminClient(AdminServiceGrpc.newBlockingStub(channel)); | ||
| return new FlyteAdminClient( | ||
| AdminServiceGrpc.newBlockingStub(channel).withDeadlineAfter(GRPC_CALL_DEADLINE_SECONDS, TimeUnit.SECONDS)); |
There was a problem hiding this comment.
This is where the Deadline has been added.
sonjaer
reviewed
Apr 17, 2023
styx-flyte-client/src/main/java/com/spotify/styx/flyte/client/FlyteAdminClient.java
Outdated
Show resolved
Hide resolved
sonjaer
approved these changes
Apr 17, 2023
sonjaer
suggested changes
Apr 17, 2023
sonjaer
reviewed
Apr 17, 2023
styx-scheduler-service/src/test/java/com/spotify/styx/StyxSchedulerTest.java
Show resolved
Hide resolved
sonjaer
reviewed
Apr 17, 2023
sonjaer
approved these changes
Apr 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Add a deadline for grpc flyte client calls.
Motivation and Context
This change is required to avoid Styx keeping broken connections for a long time generating a thread starvation problem.
Have you tested this? If so, how?
Checklist for PR author(s)
Checklist for PR reviewer(s)