This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Set scheduler as host header #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonjaer
commented
Apr 17, 2023
styx-api-service/src/main/java/com/spotify/styx/api/SchedulerProxyResource.java
Outdated
Show resolved
Hide resolved
honnix
reviewed
Apr 17, 2023
styx-api-service/src/main/java/com/spotify/styx/api/SchedulerProxyResource.java
Outdated
Show resolved
Hide resolved
styx-api-service/src/main/java/com/spotify/styx/api/SchedulerProxyResource.java
Outdated
Show resolved
Hide resolved
styx-api-service/src/main/java/com/spotify/styx/api/SchedulerProxyResource.java
Outdated
Show resolved
Hide resolved
honnix
reviewed
Apr 17, 2023
styx-api-service/src/main/java/com/spotify/styx/api/SchedulerProxyResource.java
Outdated
Show resolved
Hide resolved
…roxyResource.java Co-authored-by: Honnix <honnix@users.noreply.github.com>
honnix
reviewed
Apr 17, 2023
styx-api-service/src/main/java/com/spotify/styx/api/SchedulerProxyResource.java
Outdated
Show resolved
Hide resolved
…roxyResource.java
honnix
approved these changes
Apr 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Currently the host header is just reused from the old request, while it should be the host of styx scheduler.
Motivation and Context
Have you tested this? If so, how?
Checklist for PR author(s)
Checklist for PR reviewer(s)