Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Commit

Permalink
JSHint: Tighten function complexity requirements
Browse files Browse the repository at this point in the history
And refactor Analyzer.toString() that had become too unreadable.
  • Loading branch information
Johan Walles committed Nov 13, 2014
1 parent ac49776 commit f27e9c6
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .jshintrc
Expand Up @@ -15,5 +15,5 @@
"undef": true,
"unused": true,
"maxdepth": 4,
"maxcomplexity": 10
"maxcomplexity": 6
}
40 changes: 22 additions & 18 deletions analyze.js
Expand Up @@ -138,6 +138,27 @@ function Thread(line) {
this._frames = [];
}

function toStackWithHeadersString(stack, threads) {
var string = '';
if (threads.length > 4) {
string += "" + threads.length + " threads with this stack:\n";
}

// Print thread headers for this stack in alphabetic order
var headers = [];
for (var k = 0; k < threads.length; k++) {
headers.push(threads[k].toHeaderString());
}
headers.sort();
for (var l = 0; l < headers.length; l++) {
string += headers[l] + '\n';
}

string += stack;

return string;
}

// Create an analyzer object
function Analyzer(text) {
this._analyze = function(text) {
Expand Down Expand Up @@ -219,25 +240,8 @@ function Analyzer(text) {
asString += "" + this.threads.length + " threads found:\n";
for (var j = 0; j < stacks.length; j++) {
var currentStack = stacks[j];

asString += '\n';

var threads = stacksToThreads[currentStack];
if (threads.length > 4) {
asString += "" + threads.length + " threads with this stack:\n";
}

// Print thread headers for this stack in alphabetic order
var headers = [];
for (var k = 0; k < threads.length; k++) {
headers.push(threads[k].toHeaderString());
}
headers.sort();
for (var l = 0; l < headers.length; l++) {
asString += headers[l] + '\n';
}

asString += currentStack;
asString += '\n' + toStackWithHeadersString(currentStack, threads);
}

return asString;
Expand Down

0 comments on commit f27e9c6

Please sign in to comment.