-
Notifications
You must be signed in to change notification settings - Fork 63
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(eslint-config-react): Add
static-variables
to react/sort-comp
`eslint-plugin-react` was updated (jsx-eslint/eslint-plugin-react#2408) to support a new `static-variables` option to `react/sort-comp`. With this change, our linting started breaking. After some investigation, it turns out that `statics` seems to refer to some old `React.createClass` option, so static variables actually fell into the check for `static-methods`. Now that is fixed and `static-methods` only check for methods and `static-variables` only check for variables. So it doesn't seem like a breaking change, but we seem to have misused the options a bit. By only adding `static-variables` to our list we should still support older apps using `React.createClass` (if any), and everything will work again like before.
- Loading branch information
Showing
3 changed files
with
34 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters