feat: prettier 2.0; update project to use top-level lint and format #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updating the project to use prettier 2.0 BREAKING CHANGE: prettier 2.0 may introduce breaking changes
fastfrwrd
commented
Apr 27, 2020
| "extends": ["@spotify", "@spotify/eslint-config-oss"], | ||
| "ignorePatterns": [ | ||
| "__fixtures__", | ||
| "packages/create-web-scripts-library/template" |
There was a problem hiding this comment.
.eslintignores don't seem to work if they are nested, unfortunately.
fastfrwrd
pushed a commit
that referenced
this pull request
Apr 28, 2020
…312) - updating the project to use prettier 2.0 BREAKING CHANGE: prettier 2.0 may introduce breaking changes
fastfrwrd
pushed a commit
that referenced
this pull request
Apr 28, 2020
…312) - updating the project to use prettier 2.0 BREAKING CHANGE: prettier 2.0 may introduce breaking changes
fastfrwrd
pushed a commit
that referenced
this pull request
Apr 28, 2020
…312) - updating the project to use prettier 2.0 BREAKING CHANGE: prettier 2.0 may introduce breaking changes
fastfrwrd
pushed a commit
that referenced
this pull request
Apr 28, 2020
* build(web-scripts): use commander 5 (#314) BREAKING CHANGE: running web-scripts without arguments exits code 1 now instead of exiting 0 * feat: prettier 2.0; update project to use top-level lint and format (#312) - updating the project to use prettier 2.0 BREAKING CHANGE: prettier 2.0 may introduce breaking changes * improvement(web-scripts): make stylecheck and typecheck default for lint (#310) * feat: prettier 2.0; update project to use top-level lint and format - updating the project to use prettier 2.0 BREAKING CHANGE: prettier 2.0 may introduce breaking changes * improvement(web-scripts): make stylecheck and typecheck default for lint the lint script will now default typechecking and stylechecking to true by default. You may shut these off with `--no-typecheck` and `--no-stylecheck`. BREAKING CHANGE: Users who have projects incompatible with TypeScript checks or with projects that do not user prettier will now fail yarn lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: prettier 2.0 may introduce breaking changes