major release- 7.0.0 #318
Merged
major release- 7.0.0 #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastfrwrd
force-pushed
the
7.0-release
branch
2 times, most recently
from
4d55c46
to
c4dcfb9
Compare
added 3 commits
April 28, 2020 09:39
BREAKING CHANGE: running web-scripts without arguments exits code 1 now instead of exiting 0
…312) - updating the project to use prettier 2.0 BREAKING CHANGE: prettier 2.0 may introduce breaking changes
…int (#310) * feat: prettier 2.0; update project to use top-level lint and format - updating the project to use prettier 2.0 BREAKING CHANGE: prettier 2.0 may introduce breaking changes * improvement(web-scripts): make stylecheck and typecheck default for lint the lint script will now default typechecking and stylechecking to true by default. You may shut these off with `--no-typecheck` and `--no-stylecheck`. BREAKING CHANGE: Users who have projects incompatible with TypeScript checks or with projects that do not user prettier will now fail yarn lint.
fastfrwrd
commented
Apr 28, 2020
| .split('\n') | ||
| .forEach(dbg); | ||
| if (resp.stdout) resp.stdout.toString().split('\n').forEach(dbg); | ||
| if (resp.stderr) resp.stderr.toString().split('\n').forEach(dbg); |
There was a problem hiding this comment.
this change due to some updated prettier defaults.
fastfrwrd
commented
Apr 28, 2020
| @@ -26,7 +26,7 @@ module.exports = { | |||
| trailingComma: 'all', | |||
| // bracketSpacing: true, | |||
| // jsxBracketSameLine: false, | |||
| // arrowParens: 'avoid', | |||
| arrowParens: 'avoid', | |||
There was a problem hiding this comment.
prettier changed its default value. I personally think we should talk about changing the arrowParens value, but maybe for a future major.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
landing three breaking changes at once to release 7.0.0!