Fix user having to log in after token refresh #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where the get_cached_token method returns None instead of the cached token object, meaning that users have to login again when the initial token expires. The problem has two aspects: - The first time the user calls get_cached_token after token expiration, the token is refreshed but the "new_token_info" object is not returned. - The second time the user calls get_cached_token after token expiration, the scope check fails, because the refresh_access_token method didn't include the "scope" key when it cached the new token_info results.
plamere
added a commit
that referenced
this pull request
Aug 17, 2014
Fix user having to log in after token refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix get_cached_token method failing to return refreshed tokens, meaning that users have to log in when the token expires. Full explanation in commit message: mattduck/spotipy@72d13dd.