Query::whereFieldSql bug when providing more than one parameter #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this PR do? |
|
@marcojetson Can you please add a test for this - preferably a test that would not pass before, and one that does now with these new changes? |
|
@marcojetson Can you add tests for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query::whereFieldSql fails to populate more than one placeholder
e.g.
$query->whereFieldSql('DATE(created)', 'BETWEEN ? AND ?', ['2016-01-01', '2017-01-01']);results in "WHERE DATE(created) BETWEEN '2016-01-01' AND '2016-01-01'" because callback is shifting from $params but $params is not passing by reference... so it's just using first value every time