Constrain CQP subqueries to span match #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #289, the subquery
cqp2sometimes yields more matches within a match of the parent querycqp.Aside from the "vara säker att" example by @janiemi, we've seen this in the NPEGL corpus (restricted access). Clicking the CC.Fi category opens a KWIC with 4 matches, where there should be only 2. Unlike #289, this is not because we are reducing by a structural attribute, but because NPEGL has mode-specific code that merges some rows.
The suggestion in this pull request is to wrap the subquery in
<match> [...] []* </match>. This ensures that each match corresponds to one parent match.