Remove deprecated UTF8_decode from FpdfOutput.php #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
since utf8_decode has been deprecated on PHP8.2 it spits out notices.
I use FPDF also on other places and had the same there. According to the FPDF FAQ no.3 they recommend to use iconv() to convert 'UTF8' to 'windows-1252' which is expected.
The tests no produce errors, since I didn't manage to renew the .png-files in the QrCodes Test data.
Alltough the PDF's looked correct and scanning the QR-Code with my ebanking-app worked.
Thanks a lot for your work!
philipp