Node#value crashes

spraints · Feb 26, 2011 · ef3122a · ef3122a
1 parent b9ecd40
commit ef3122a
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/lib/capybara/driver/webkit/node.rb b/lib/capybara/driver/webkit/node.rb
@@ -9,13 +9,28 @@ def [](name)
     end
 
     def value
-      raise NotImplementedError
+      invoke "value"
     end
 
     def set(value)
       raise NotImplementedError
     end
 
+    # akephalos
+    # def set(value)
+    #   if tag_name == 'textarea'
+    #     node.value = value.to_s
+    #   elsif tag_name == 'input' and type == 'radio'
+    #     click
+    #   elsif tag_name == 'input' and type == 'checkbox'
+    #     if value != self['checked']
+    #       click
+    #     end
+    #   elsif tag_name == 'input'
+    #     node.value = value.to_s
+    #   end
+    # end
+
     def select_option
       raise NotImplementedError
     end

diff --git a/spec/driver_spec.rb b/spec/driver_spec.rb
@@ -9,6 +9,9 @@
           <script type="text/javascript">
             document.write("<p id='greeting'>he" + "llo</p>");
           </script>
+          <form action="/" method="GET">
+            <textarea id="only-textarea">what a wonderful area for text</textarea>
+          </form>
         </body></html>
       HTML
       [200,
@@ -58,6 +61,9 @@
           <script type="text/javascript">
             document.write("<p id='greeting'>he" + "llo</p>");
           </script><p id="greeting">hello</p>
+          <form action="/" method="GET">
+            <textarea id="only-textarea">what a wonderful area for text</textarea>
+          </form>
         
 </body></html>}
   end
@@ -129,4 +135,8 @@
   it "returns a node's tag name" do
     subject.find("//p").first.tag_name.should == "p"
   end
+
+  it "fetches the value of a textarea" do
+    subject.find("//textarea").first.value.should == "what a wonderful area for text"
+  end
 end
diff --git a/src/capybara.js b/src/capybara.js
@@ -28,6 +28,11 @@ Capybara = {
 
   tagName: function(index) {
     return this.nodes[index].tagName.toLowerCase();
+  },
+
+  value: function(index) {
+    return this.nodes[index].value;
   }
+
 };