Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable debugging for any address #109

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable debugging for any address #109

wants to merge 2 commits into from

Conversation

tca3
Copy link

@tca3 tca3 commented Aug 25, 2022

Fixes #101

raboof
raboof reviewed Aug 25, 2022
View reviewed changes
src/main/scala/spray/revolver/DebugSettings.scala Outdated
@@ -2,7 +2,7 @@ package spray.revolver

case class DebugSettings(port: Int = 5005, suspend: Boolean = false) {
def toCmdLineArg: String =
"-agentlib:jdwp=transport=dt_socket,server=y,suspend=%s,address=%d".format(b2str(suspend), port)
"-agentlib:jdwp=transport=dt_socket,server=y,suspend=%s,address=*:%d".format(b2str(suspend), port)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, would this open the port on 0.0.0.0?

If you'd do that on your host system, it'd mean the port would be open for anyone who can connect to it. I expect the debugging interface allows arbitrary code execution, so perhaps this should be an opt-in option instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've updated the code to have it as an optional parameter

raboof
raboof approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable debugging for any address
2 participants
@tca3 @raboof