Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix still in edit mode #214

Closed
wants to merge 1 commit into from
Closed

Conversation

lemaiwo
Copy link
Contributor

@lemaiwo lemaiwo commented May 17, 2023

The first upload works fine, the second one raises a message to close the application because of open changes. for some reason, the earlier created entries are still in the model as pending changes. A resetChanges solves this problem.

I'm not sure this is the best problem, we should find the root cause why the entries are still in pendingChanges after the submit

@marianfoo
Copy link
Member

can you tell me a bit more about what and where you uploading so i can recreate the error.
With activate draft? I guess OData V4?

@lemaiwo
Copy link
Contributor Author

lemaiwo commented May 17, 2023

Odata v2 without draft

@marianfoo
Copy link
Member

marianfoo commented May 17, 2023

sorry, still can´t recreate it
You are in a Fiori Elements app? What UI5 Version?
Anymore other configuration?
Can you share code?

@lemaiwo
Copy link
Contributor Author

lemaiwo commented May 17, 2023

It's a fiori element list report on top of s/4hana2022 using rap with ui5 version 1.96. It already occurred without any changes in the app. I'll check if I can share more details but it will be difficult for the rap part.

@marianfoo
Copy link
Member

i think i can recreate it.
Im going in edit mode, upload a file and on upload and creation of the data it leaves the edit mode.
So before i upload a file i can edit already existing data.
When i edit data and then upload a file a get this popup.

@marianfoo
Copy link
Member

have a look if #223 helpes you with version 0.17.3

@marianfoo
Copy link
Member

fixed with #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants