Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target netstandard2.0 #178

Merged
merged 4 commits into from Aug 7, 2023
Merged

Target netstandard2.0 #178

merged 4 commits into from Aug 7, 2023

Conversation

Jonarw
Copy link
Contributor

@Jonarw Jonarw commented Aug 7, 2023

See issue #176.

Notes:

  • Should the changelog be updated? I did not do it for now, as it seems to be not quite up to date.
  • Changed the TargetFrameworks for XLParser.Tests to net462;net6, as netcoreapp3.1 is also out of support

WillemJann
WillemJann approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@WillemJann WillemJann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I've added commits so that not only the XLParser project, but also XLParser.Web and IronyExplorer use the latest Irony 1.2.0.

I've tested both targets net462 and netstandard2.0 of the XLParser project, everything works well and all unit test pass. Merging the PR.

This was linked to issues Aug 7, 2023
Update Irony.NetCore package #175
Closed
Target netstandard2.0 #176
Closed
@WillemJann WillemJann merged commit 6e7e39d into spreadsheetlab:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillemJann WillemJann WillemJann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target netstandard2.0 Update Irony.NetCore package
2 participants
@Jonarw @WillemJann