Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache fixes #42

Closed
wants to merge 2 commits into from
Closed

Cache fixes #42

wants to merge 2 commits into from

Conversation

j15e
Copy link
Contributor

@j15e j15e commented Oct 3, 2012

This way an API error is now raised every time but we still avoid hitting the API every time.

Fix regarding #38

@j15e
Fix timing cache key naming
3abf017
@j15e
Cache responses errors (see spree-contrib#38)
15d008b 
Otherwise the error is only shown on first user attempt
@jumph4x
Copy link
Contributor

jumph4x commented Oct 4, 2012

Needs a rebase now, unfortunately.

Appreciate the quality commits!

@j15e
Copy link
Contributor Author

j15e commented Oct 4, 2012

I'll do when I get back to office

@j15e j15e closed this Oct 4, 2012
@j15e j15e mentioned this pull request Oct 4, 2012
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j15e @jumph4x