Deal with reality that not all calculable objects have stock_locations. #96
Conversation
| @@ -28,8 +28,10 @@ def compute(object) | |||
| end | |||
|
|
|||
| if object.is_a?(Spree::Shipment) | |||
| return nil unless defined? object.stock_location_id | |||
There was a problem hiding this comment.
In what case would a shipment not have a stock location?
There was a problem hiding this comment.
Actually not sure why order objects are getting passed around here, but appears that ALL calculable objects hit all compute methods.
As to when a shipment may not have a location, I suspect with digital content, that would be the case. Not my case here.
This is relevant to issues I have raised in the past where it seems we are passing just about anything to these shipment calculators. spree_active_shipping sees, Order objects, Shipment objects and Package objects. Not sure if perhaps an order object is getting passed for every stock location and I am seeing this because not every location has every variant.
I think it deserves more investigation by someone who understands a bit more about what is going on.
Here is a previous comment I offered: #80 (comment)
|
Where is this |
…ock::Package object Fixes #96 Conflicts: app/models/spree/calculator/shipping/active_shipping/base.rb
Not completely sure this is the right solution. Seems we should not be sending calculables to shipping calculators without a stock_location.
What say you @radar, @LBRapid, @BDQ
This is in response to spree/spree#3381