[VULN] Fixing #53

spree-contrib · Apr 12, 2013 · 1e15645 · 1e15645
1 parent 38cb290
commit 1e15645
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/app/controllers/spree/checkout_controller_decorator.rb b/app/controllers/spree/checkout_controller_decorator.rb
@@ -11,12 +11,16 @@ def set_addresses
 
     if params[:order][:ship_address_id].to_i > 0
       params[:order].delete(:ship_address_attributes)
+
+      Spree::Address.find(params[:order][:ship_address_id]).user_id != spree_current_user.id && raise("Frontend address forging")
     else
       params[:order].delete(:ship_address_id)
     end
 
     if params[:order][:bill_address_id].to_i > 0
       params[:order].delete(:bill_address_attributes)
+
+      Spree::Address.find(params[:order][:bill_address_id]).user_id != spree_current_user.id && raise("Frontend address forging")
     else
       params[:order].delete(:bill_address_id)
     end