Move ADDRESS_FIELDS global constant to Spree Preference

[felixbuenemann]

I think it's a really bad idea to have a global constant ADDRESS_FIELDS. Not only willy it raise constant redefined warning if you need to change it, it also could override another constant, because it isn't namespaced into a class.

I think it would be a much better idea to store this as a spree addressbook preference:

class Spree::AddressBookConfiguration
  # ...
  preference :address_fields, :string, :default => "firstname lastname company address1 address2 city state zipcode country phone"
end

Then in the form code:

Spree::AddressBook::Config.address_fields.split.each do |field|

If you agree, I'd be happy to make a PR.

[felixbuenemann]

@romul No response on this, are you flooded atm?

[iloveitaly]

This is a great idea. Closing this issue out… I'll look for a PR!

Thanks!