This repository has been archived by the owner on Nov 29, 2019. It is now read-only.
Major changes and clean up #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed cucumber
…ustom Conflicts: app/views/spree/shared/paypal_express_confirm.html.erb
| @@ -145,8 +147,15 @@ def paypal_finish | |||
| Rails.logger.error ppx_auth_response.to_yaml | |||
| end | |||
|
|
|||
| @order.update_attribute(:state, "complete") | |||
There was a problem hiding this comment.
@radar any idea why we are not using @order.complete! to preserve order's state callbacks ?
There was a problem hiding this comment.
There are some state events triggered when this method is called, and those fail. Therefore we set this manually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My branch name is called 'custom' because my first intention was to make spree_store_credits compatible with spree_paypal_express, but I end up fixing a lot of features and though it would be great if this get merged into spree's repo:
The spec coverage is not as good as it should be, but I tried to add some spec and setup integrations test if anyone wants to help with.
This PR is actually tested with preferred_review set to true and deployed on production, but would love any feedback.