Add scope customization when provider initials. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some provider doesn't support 'email' as their scope. This fix issue spree-contrib#200
houndci-bot
reviewed
May 4, 2017
| Devise.setup do |config| | ||
| config.omniauth provider, key, secret, setup: true, scope: 'email', info_fields: 'email, name' | ||
| config.omniauth provider, key, secret, setup: true, scope: scope, info_fields: 'email, name' |
There was a problem hiding this comment.
Line is too long. [98/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -36,7 +36,7 @@ def self.activate | |||
| end | |||
|
|
|||
| # Setup all OAuth providers | |||
| def self.init_provider(provider) | |||
| def self.init_provider(provider, scope='email') | |||
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Thanks @Ronaldoooo 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some provider doesn't support 'email' as their scope. This fix issue #200